Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the releasing operation to have the step to maintain GitHub milestones #1263

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Update the releasing operation to have the step to maintain GitHub milestones #1263

merged 2 commits into from
Jun 8, 2021

Conversation

seratch
Copy link
Member

@seratch seratch commented Jun 8, 2021

Summary

This pull request updates the maintainers' guide to have the step to maintain GitHub milestones.

Requirements (place an x in each [ ])

@seratch seratch added pkg:web-api applies to `@slack/web-api` pkg:rtm-api applies to `@slack/rtm-api` pkg:webhook applies to `@slack/webhook` pkg:logger applies to `@slack/logger` pkg:types applies to `@slack/types` pkg:oauth applies to `@slack/oauth-helper` pkg:socket-mode applies to `@slack/socket-mode` release labels Jun 8, 2021
stevengill
stevengill reviewed Jun 8, 2021
View reviewed changes
Copy link
Member

@stevengill stevengill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition! Maybe we should have a note about moving unfinished milestone issues into the next milestone as well.

mwbrooks
mwbrooks approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a suggestion based on @stevengill's feedback!

.github/maintainers_guide.md Show resolved Hide resolved
@seratch @mwbrooks
Update .github/maintainers_guide.md
0d280ab 
Co-authored-by: Michael Brooks <michael@michaelbrooks.ca>
@seratch seratch merged commit 5857ad1 into slackapi:main Jun 8, 2021
@seratch seratch deleted the update-release-ops branch June 8, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengill stevengill stevengill left review comments

@mwbrooks mwbrooks mwbrooks approved these changes

@misscoded misscoded misscoded approved these changes

Assignees
No one assigned
Labels
pkg:logger applies to `@slack/logger` pkg:oauth applies to `@slack/oauth-helper` pkg:rtm-api applies to `@slack/rtm-api` pkg:socket-mode applies to `@slack/socket-mode` pkg:types applies to `@slack/types` pkg:web-api applies to `@slack/web-api` pkg:webhook applies to `@slack/webhook` release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@seratch @mwbrooks @stevengill @misscoded